[PATCH] cobalt: allow to compile without __USE_LARGEFILE64

Norbert Lange nolange79 at gmail.com
Fri Apr 17 10:39:55 CEST 2020


True, rolled a v2 after reading up a bit.
The new check was ultimately copied over from musl, should suit some
additional cases.
(I guess I wasn't running into it till now, as I mostly use _GNU_SOURCE)

Norbert

Am Fr., 17. Apr. 2020 um 08:10 Uhr schrieb Jan Kiszka <jan.kiszka at siemens.com>:
>
> On 16.04.20 21:44, Norbert Lange via Xenomai wrote:
> > A header uses the off64_t which is only conditionally available,
> > causing compile failures.
> > The macro might be necessary to compile cobalt libraries,
> > but should not be needed for software depending on them.
> >
> > Signed-off-by: Norbert Lange <nolange79 at gmail.com>
> > ---
> >   include/cobalt/sys/mman.h | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/include/cobalt/sys/mman.h b/include/cobalt/sys/mman.h
> > index 1c47777a2..9428c4cec 100644
> > --- a/include/cobalt/sys/mman.h
> > +++ b/include/cobalt/sys/mman.h
> > @@ -31,8 +31,10 @@ extern "C" {
> >   COBALT_DECL(void *, mmap(void *addr, size_t length, int prot, int flags,
> >                        int fd, off_t offset));
> >
> > +#ifdef __USE_LARGEFILE64
>
> Good catch, but I think this should be _LARGEFILE64_SOURCE instead.
>
> Jan
>
> >   COBALT_DECL(void *, mmap64(void *addr, size_t length, int prot, int flags,
> >                          int fd, off64_t offset));
> > +#endif
> >
> >   #ifdef __cplusplus
> >   }
> >
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux



More information about the Xenomai mailing list