[PATCH Dovetail 13/13] cobalt/syscall: pipeline: abstract syscall entry points

Jan Kiszka jan.kiszka at siemens.com
Mon Jan 11 13:11:00 CET 2021


On 09.01.21 11:58, Philippe Gerum wrote:
> 
> Jan Kiszka <jan.kiszka at siemens.com> writes:
> 
>> On 02.01.21 10:33, Philippe Gerum wrote:
>>> From: Philippe Gerum <rpm at xenomai.org>
>>>
>>> The I-pipe and Dovetail differ only marginally with respect to syscall
>>> handling. Abstract only the few details we need to cope with both
>>> interfaces.
>>>
>>> No functional change is introduced.
>>>
>>> Signed-off-by: Philippe Gerum <rpm at xenomai.org>
>>> ---
>>>  .../cobalt/kernel/ipipe/pipeline/kevents.h    |  3 ++
>>>  .../cobalt/kernel/ipipe/pipeline/pipeline.h   |  2 ++
>>>  include/cobalt/kernel/sched.h                 |  2 --
>>>  kernel/cobalt/ipipe/Makefile                  |  2 +-
>>>  kernel/cobalt/ipipe/syscall.c                 | 29 +++++++++++++++++++
>>>  kernel/cobalt/posix/process.h                 |  3 --
>>>  kernel/cobalt/posix/syscall.c                 | 28 ++++--------------
>>>  kernel/cobalt/posix/syscall.h                 |  7 +++++
>>>  8 files changed, 47 insertions(+), 29 deletions(-)
>>>  create mode 100644 kernel/cobalt/ipipe/syscall.c
>>>
>>> diff --git a/include/cobalt/kernel/ipipe/pipeline/kevents.h b/include/cobalt/kernel/ipipe/pipeline/kevents.h
>>> index 30425a96b..2f186a57e 100644
>>> --- a/include/cobalt/kernel/ipipe/pipeline/kevents.h
>>> +++ b/include/cobalt/kernel/ipipe/pipeline/kevents.h
>>> @@ -7,6 +7,9 @@
>>>  #ifndef _COBALT_KERNEL_IPIPE_KEVENTS_H
>>>  #define _COBALT_KERNEL_IPIPE_KEVENTS_H
>>>  
>>> +#define KEVENT_PROPAGATE   0
>>> +#define KEVENT_STOP        1
>>> +
>>>  struct cobalt_process;
>>>  struct cobalt_thread;
>>>  
>>> diff --git a/include/cobalt/kernel/ipipe/pipeline/pipeline.h b/include/cobalt/kernel/ipipe/pipeline/pipeline.h
>>> index 0ffc9b00b..fb0465fb2 100644
>>> --- a/include/cobalt/kernel/ipipe/pipeline/pipeline.h
>>> +++ b/include/cobalt/kernel/ipipe/pipeline/pipeline.h
>>> @@ -11,6 +11,8 @@
>>>  
>>>  #include <pipeline/machine.h>
>>>  
>>> +#define xnsched_realtime_domain  cobalt_pipeline.domain
>>> +
>>
>> Why not use the chance and call also this xnsched_primary_domain?
> 
> Agreed on the reasoning. However I'll push that change on top top of my
> current patch queue, without affecting this intermediate patch only for
> a cosmetic change, not to cause useless merge conflicts - I have several
> other series of changes pending for kernel/cobalt/ipipe/{init, intr}.c
> typically.
> 

OK. All now applied (with v2 of patch 7).

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux



More information about the Xenomai mailing list